Attention is currently required from: neels.

View Change

3 comments:

• File pySim/esim/saip/param_source.py:

  • Patch Set #3, Line 33: abstract

    if it's abstract, should it be an abc.ABC ?

  • Patch Set #3, Line 132: RandomDigitSource

    IMHO it's a bit unintuitive that the IncDigit inherits from RandomDigit. Maybe add a DigitSource from which both IncDigit + RandomDigit inherits?

  • Patch Set #3, Line 133: 'incrementing sequence of digits'

    cosmetic: the docstring here uses single-quotes, below for the method it uses double-quotes. This looks a bit inconsistent. In the existing code base, I think we always use multi-line """ style comments for this, irrespective if the actual comment is just a single line. That makes it easier to expand it later on without having to change quoting style.

To view, visit change 40096. To unsubscribe, or for help writing mail filters, visit settings.