Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email )
Change subject: vlr: add a logging layer ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File include/osmocom/vlr/vlr.h:
https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/77a4c0b8_7bb40201?usp=... : PS2, Line 505: extern int g_vlr_log_cat[_OSMO_VLR_LOGC_MAX]; this should be kept as static (or at least internal to the lib, add a private header if needed.).
https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/8b90ada2_6df12b38?usp=... : PS2, Line 507: #define LOGVLR(lvl, fmt, args...) LOGP(g_vlr_log_cat[OSMO_VLR_LOGC_VLR], lvl, fmt, ## args) This should also be in private headers.