[M] Change in osmo-msc[master]: vlr: add a logging layer

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email ) Change subject: vlr: add a logging layer ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/77a4c0b8_7bb40201?usp… : PS2, Line 505: extern int g_vlr_log_cat[_OSMO_VLR_LOGC_MAX]; this should be kept as static (or at least internal to the lib, add a private header if needed.). https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/8b90ada2_6df12b38?usp… : PS2, Line 507: #define LOGVLR(lvl, fmt, args...) LOGP(g_vlr_log_cat[OSMO_VLR_LOGC_VLR], lvl, fmt, ## args) This should also be in private headers. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b Gerrit-Change-Number: 38410 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 22:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes