Attention is currently required from: lynxis lazus.

Patch set 2:Code-Review -1

View Change

2 comments:

• File include/osmocom/vlr/vlr.h:

  • Patch Set #2, Line 505: extern int g_vlr_log_cat[_OSMO_VLR_LOGC_MAX];

    this should be kept as static (or at least internal to the lib, add a private header if needed.).

  • Patch Set #2, Line 507: #define LOGVLR(lvl, fmt, args...) LOGP(g_vlr_log_cat[OSMO_VLR_LOGC_VLR], lvl, fmt, ## args)

    This should also be in private headers.

To view, visit change 38410. To unsubscribe, or for help writing mail filters, visit settings.