Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email )
Change subject: ms_power_control: Apply defaults during reset ......................................................................
Patch Set 1:
(2 comments)
File src/common/power_control.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/78b081f1_ca9e2c32?usp=... : PS1, Line 150: /* XXX: should we use the maximum power level instead of 0 dBm? */ Not critical, but I would prefer to see this comment before the `state->max = ms_pwr_ctl_lvl(...)` since it's related exactly to that line.
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/21658902_2e7f4e1b?usp=... : PS1, Line 2054: XXX: should we use the maximum power level instead of 0 dBm This comment does not belong here anymore. It's related to that line:
``` lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); // 0 dBm
```
so I suggest removing it.