Attention is currently required from: pespin.

View Change

2 comments:

• File src/common/power_control.c:

  • Patch Set #1, Line 150: /* XXX: should we use the maximum power level instead of 0 dBm? */

    Not critical, but I would prefer to see this comment before the `state->max = ms_pwr_ctl_lvl(...)` since it's related exactly to that line.

• File src/common/rsl.c:

  • Patch Set #1, Line 2054: XXX: should we use the maximum power level instead of 0 dBm

    This comment does not belong here anymore. It's related to that line:

    ```
    lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); // 0 dBm

    ```

    so I suggest removing it.

To view, visit change 41795. To unsubscribe, or for help writing mail filters, visit settings.