[L] Change in osmo-mgw[master]: mgw: CRCX: Split mgcp header pars parsing into a previous step

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email ) Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ...................................................................... Patch Set 2: (1 comment) File src/libosmo-mgcp/mgcp_msg.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/bfa942d8_65dc74d0?usp… : PS2, Line 172: * \returns 0 when parsing was successful, negative (MGCP cause code) on error. */ The error returns here are not negative. You should change the code to return negative errors and also the checks in `handle_create_conn()`. Also having defines for the errors (protocol error, unsupported parameter, ..) here and in `mgcp_parse_header()` would help readability - maybe in a follow-up commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ee5158c254213203830fe9c38de11c15b4b19c1 Gerrit-Change-Number: 39224 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2025 16:15:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No