Attention is currently required from: pespin.

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_msg.c:

  • Patch Set #2, Line 172: * \returns 0 when parsing was successful, negative (MGCP cause code) on error. */

    The error returns here are not negative. You should change the code to return negative errors and also the checks in `handle_create_conn()`.

    Also having defines for the errors (protocol error, unsupported parameter, ..) here and in `mgcp_parse_header()` would help readability - maybe in a follow-up commit.

To view, visit change 39224. To unsubscribe, or for help writing mail filters, visit settings.