Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email )
Change subject: vlr: use correct types for vlr_timer ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/vlr/vlr.h:
https://gerrit.osmocom.org/c/osmo-msc/+/38356/comment/fd98a2a0_cf02fad1?usp=... : PS1, Line 427: unsigned long vlr_timer(struct vlr_instance *vlr, int timer); so the point here is that this function actually returns the timer value right? Can we please rename it to "vlr_timer_val()", "vlr_timer_val_secs()" or alike? Otherwise it's difficult to understand what is it returning...