Attention is currently required from: lynxis lazus.

Patch set 1:Code-Review +1

View Change

1 comment:

• File include/osmocom/vlr/vlr.h:

  • Patch Set #1, Line 427: unsigned long vlr_timer(struct vlr_instance *vlr, int timer);

    so the point here is that this function actually returns the timer value right? Can we please rename it to "vlr_timer_val()", "vlr_timer_val_secs()" or alike? Otherwise it's difficult to understand what is it returning...

To view, visit change 38356. To unsubscribe, or for help writing mail filters, visit settings.