17 Jun
2022
17 Jun
'22
8:09 p.m.
Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244
)
Change subject: add pfcp_endpoint
......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/pfcp/pfcp_endpoint.h:
https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/a59e5f12_e07e366e
PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx;
agreed
there are various function pointers in
osmocom code that are not named *_cb,
in:
struct osmo_fsm_state,
struct osmo_fsm,
struct vlr_ops,
struct call_leg (in sipcon),
struct sccp_ran_ops,
struct convert_cpu_context,
struct e1inp_driver,
to name some.
my personal choice is to not add _cb.
https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/eba31e39_22fd1ccd
PS3, Line 104:
In general, the question is whether 'struct
osmo_pfcp_endpoint' is supposed to be publicly exposed t […]
every time i have
written API with opaque structs, i have regretted it from the extensive work required to
introduce API functions for every little detail.
Any ABI breakage is fixed by simple recompilation.
Examples of public structs in osmocom are:
struct osmo_fsm,
struct osmo_fsm_inst,
struct log_info,
struct msgb,
struct rate_ctr*,
struct stat_item*,
struct osmo_fd,
struct osmo_tdef,
struct mgcp_client_conf,
struct sccp_connection,
to name some.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac
Gerrit-Change-Number: 28244
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Jun 2022 20:09:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment