Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File include/osmocom/pfcp/pfcp_endpoint.h:

  • Patch Set #3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx;

    agreed

    there are various function pointers in osmocom code that are not named *_cb,
    in:
    struct osmo_fsm_state,
    struct osmo_fsm,
    struct vlr_ops,
    struct call_leg (in sipcon),
    struct sccp_ran_ops,
    struct convert_cpu_context,
    struct e1inp_driver,
    to name some.

    my personal choice is to not add _cb.

  • Patch Set #3, Line 104:

    In general, the question is whether 'struct osmo_pfcp_endpoint' is supposed to be publicly exposed t […]

    every time i have written API with opaque structs, i have regretted it from the extensive work required to introduce API functions for every little detail.
    Any ABI breakage is fixed by simple recompilation.

    Examples of public structs in osmocom are:
    struct osmo_fsm,
    struct osmo_fsm_inst,
    struct log_info,
    struct msgb,
    struct rate_ctr*,
    struct stat_item*,
    struct osmo_fd,
    struct osmo_tdef,
    struct mgcp_client_conf,
    struct sccp_connection,
    to name some.

To view, visit change 28244. To unsubscribe, or for help writing mail filters, visit settings.