Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 )
Change subject: WIP support for ericsson CCU ......................................................................
Patch Set 1:
(10 comments)
File src/ericsson-rbs/er_ccu_descr.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/652d411e_2102611f PS1, Line 8: typedef void (er_ccu_empty) (struct er_ccu_descr * ccu_descr); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/3fec219a_d6f9f60f PS1, Line 9: typedef void (er_ccu_rx) (struct er_ccu_descr * ccu_descr, const ubit_t *bits, unsigned int num_bits); "foo * bar" should be "foo *bar"
File src/ericsson-rbs/er_ccu_if.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/be7bda63_0f8ae665 PS1, Line 9: void er_ccu_if_tx(struct er_ccu_descr *ccu_descr, const ubit_t * bits, unsigned int num_bits); "foo * bar" should be "foo *bar"
File src/ericsson-rbs/er_ccu_if.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/133609f7_1526e99f PS1, Line 122: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/e9ae1010_95972c97 PS1, Line 232: if (!ccu_descr->trau_sync_fi) { braces {} are not necessary for single statement blocks
File src/ericsson-rbs/er_ccu_l1_if.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/160a5c48_0e7f4bec PS1, Line 178: "afn_ul=%u (computed) != afn_ul=%u (sync-ind) => delta=%u \n", afn_ul, unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/3507490f_9949aa6b PS1, Line 181: afn_ul)); Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_ul'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/635f8627_463bd23c PS1, Line 184: "afn_dl=%u (computed) != afn_dl=%u (sync-ind) => delta=%u \n", afn_dl, unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/a932cdc2_e85cffa1 PS1, Line 187: afn_dl)); Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_dl'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/349b0ec2_20b7d373 PS1, Line 248: /* We do not receive sync indications in every cycle. When traffic is transfered we won't get frame numbers 'transfered' may be misspelled - perhaps 'transferred'?