10 comments:
File src/ericsson-rbs/er_ccu_descr.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 8: typedef void (er_ccu_empty) (struct er_ccu_descr * ccu_descr);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 9: typedef void (er_ccu_rx) (struct er_ccu_descr * ccu_descr, const ubit_t *bits, unsigned int num_bits);
"foo * bar" should be "foo *bar"
File src/ericsson-rbs/er_ccu_if.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 9: void er_ccu_if_tx(struct er_ccu_descr *ccu_descr, const ubit_t * bits, unsigned int num_bits);
"foo * bar" should be "foo *bar"
File src/ericsson-rbs/er_ccu_if.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 232: if (!ccu_descr->trau_sync_fi) {
braces {} are not necessary for single statement blocks
File src/ericsson-rbs/er_ccu_l1_if.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 178: "afn_ul=%u (computed) != afn_ul=%u (sync-ind) => delta=%u \n", afn_ul,
unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 181: afn_ul));
Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_ul'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 184: "afn_dl=%u (computed) != afn_dl=%u (sync-ind) => delta=%u \n", afn_dl,
unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 187: afn_dl));
Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_dl'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3270):
Patch Set #1, Line 248: /* We do not receive sync indications in every cycle. When traffic is transfered we won't get frame numbers
'transfered' may be misspelled - perhaps 'transferred'?
To view, visit change 31176. To unsubscribe, or for help writing mail filters, visit settings.