Attention is currently required from: daniel.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )
Change subject: gsmtap: Hide implementation of gsmtap_inst
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File include/osmocom/core/gsmtap_util.h:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/dde5fab4_12e50e49
PS2, Line 29: int gsmtap_inst_fd(struct gsmtap_inst *gti);
This API being static inline before, means the
appsusing it actually got the implementation compiled […]
Done
File src/core/gsmtap_util.c:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/15f4bec9_25d964b7
PS2, Line 52: struct osmo_wqueue wq; /*!< the wait queue */
Sounds good to me, but have a look at
osmo_static_assert instead of OSMO_ASSERT. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Oct 2023 13:49:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment