Attention is currently required from: daniel.

Patch set 5:Code-Review +2

View Change

2 comments:

• File include/osmocom/core/gsmtap_util.h:

  • Patch Set #2, Line 29: int gsmtap_inst_fd(struct gsmtap_inst *gti);

    This API being static inline before, means the appsusing it actually got the implementation compiled […]

    Done

• File src/core/gsmtap_util.c:

  • Patch Set #2, Line 52: struct osmo_wqueue wq; /*!< the wait queue */

    Sounds good to me, but have a look at osmo_static_assert instead of OSMO_ASSERT. […]

    Done

To view, visit change 34720. To unsubscribe, or for help writing mail filters, visit settings.