Attention is currently required from: fixeria, jolly, laforge, pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 6:
(1 comment)
File include/osmocom/netif/twjit.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/3f29a244_3e59f0f… :
PS6, Line 50: struct osmo_twjit_config {
@falcon@freecalypso. […]
@pespin@sysmocom.de:
your proposal would not work for twjit config because it would break vty, or more
precisely, network operators' ability to tune twjit settings in their network
elements. Right now tw-border-mgw and tw-e1abis-mgw have twjit nodes in their vty config
trees, and the same would need to happen in OsmoBTS if it were equipped with ability to
use twrtp+twjit instead of ortp. Each block of twjit tunable settings in a network
element's vty config tree corresponds to a twjit config struct somewhere in that
network element app's data structures. Removing app-visible config structure and
having tuning APIs banging directly on twjit/twrtp instances won't work, as there is
only one vty-managed twjit config struct per app (or multiple as makes sense for that app,
such as GSM vs PSTN in tw-border-mgw), but many more instances of twrtp with twjit.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 6
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Aug 2025 19:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>