Attention is currently required from: fixeria, jolly, laforge, pespin.

View Change

1 comment:

• File include/osmocom/netif/twjit.h:

  • Patch Set #6, Line 50: struct osmo_twjit_config {

    @falcon@freecalypso. […]

    @pespin@sysmocom.de: your proposal would not work for twjit config because it would break vty, or more precisely, network operators' ability to tune twjit settings in their network elements. Right now tw-border-mgw and tw-e1abis-mgw have twjit nodes in their vty config trees, and the same would need to happen in OsmoBTS if it were equipped with ability to use twrtp+twjit instead of ortp. Each block of twjit tunable settings in a network element's vty config tree corresponds to a twjit config struct somewhere in that network element app's data structures. Removing app-visible config structure and having tuning APIs banging directly on twjit/twrtp instances won't work, as there is only one vty-managed twjit config struct per app (or multiple as makes sense for that app, such as GSM vs PSTN in tw-border-mgw), but many more instances of twrtp with twjit.

To view, visit change 39280. To unsubscribe, or for help writing mail filters, visit settings.