[M] Change in libosmo-abis[master]: e1line_dump_vty(): dump keepalive state and params

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email ) Change subject: e1line_dump_vty(): dump keepalive state and params ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: very nice! File src/e1_input_vty.c: https://gerrit.osmocom.org/c/libosmo-abis/+/36342/comment/4f307a3b_57c0460a PS1, Line 460: static void e1line_ka_dump_vty(struct vty *vty, const struct e1inp_line *line) I would suggest making clear that this is TCP keepalive: * name the function e1line_tcp_ka_dump_vty * Print "TCP Keepalive" instead of "Keepalive" -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I17bd991850333ee794ab216f474b5e045fb01fa3 Gerrit-Change-Number: 36342 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 08:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment