Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30254 )
Change subject: trxcon: make burst pointer in trxcon_phyif_burst_ind const
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30254/comment/16d42b1e_b3faaea2
PS1, Line 658: sbit_t *burst = (sbit_t *)&buf[8];
I am not making the buf[] const.
Ah I see what
you mean. Still it looks a bit weird to asign a buffer as a const pointer somewhere, and
later on modifying that pointer. Would feel a lot less strange if you edited the buffer
before assigning it as a const pointer IMHO.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30254
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I68773d247725a6dc2cbbc58b63c0fd19ffdb1a16
Gerrit-Change-Number: 30254
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Nov 2022 13:41:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment