Attention is currently required from: fixeria.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/host/trxcon/src/trx_if.c:

  • Patch Set #1, Line 658: sbit_t *burst = (sbit_t *)&buf[8];

    I am not making the buf[] const.

    Ah I see what you mean. Still it looks a bit weird to asign a buffer as a const pointer somewhere, and later on modifying that pointer. Would feel a lot less strange if you edited the buffer before assigning it as a const pointer IMHO.

To view, visit change 30254. To unsubscribe, or for help writing mail filters, visit settings.