Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 )
Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ......................................................................
Patch Set 7:
(3 comments)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/fa54e85d_492da4ca PS6, Line 704: if (msgb_length(msg) == GSM_HR_BYTES + sizeof(struct rtp_hdr)) {
Not criticial, but you could even have a switch case here: switch(msgb_length(msg))
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/867cbdb8_cbaab96b PS6, Line 705: /* Abort early in case the input format (TS 101318) already
Abort sounds like failing here. "Do nothing in case" would be far more informative imho.
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/793d9ef9_edf5f9e7 PS6, Line 1250: } else if ((rtp_end->rfc5993_hr_convert ||
Sounds like we want to have some function and put all this conditions together? It starts to be diff […]
Done