Attention is currently required from: pespin.

View Change

3 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #6, Line 704: if (msgb_length(msg) == GSM_HR_BYTES + sizeof(struct rtp_hdr)) {

    Not criticial, but you could even have a switch case here: switch(msgb_length(msg))

    Done

  • Patch Set #6, Line 705: /* Abort early in case the input format (TS 101318) already

    Abort sounds like failing here. "Do nothing in case" would be far more informative imho.

    Done

  • Patch Set #6, Line 1250: } else if ((rtp_end->rfc5993_hr_convert ||

    Sounds like we want to have some function and put all this conditions together? It starts to be diff […]

    Done

To view, visit change 31214. To unsubscribe, or for help writing mail filters, visit settings.