Attention is currently required from: Hoernchen, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41660?usp=email )
Change subject: bts-trx: define TRXD_MSG_BUF_SIZE as a more realistic lower value ......................................................................
Patch Set 4:
(2 comments)
File src/osmo-bts-trx/trx_if.h:
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/d8ca32d6_8a49027d?usp=... : PS3, Line 11: OSMO_MAX(2 * (GSM_BURST_LEN + 2), (EGPRS_BURST_LEN + 2))
`EGPRS_BURST_LEN` is known to be 3 times greater than `GSM_BURST_LEN` (because 8-PSK fits 3 bits per […]
I know, see last comment line. Still, this code here is resolved at compile time as a constant expression by any decent compiler, and it auto-explains how the value is calculated.
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/ff45fa7d_07f4d5c5?usp=... : PS3, Line 12: TRXD_BURST_SIZE_MAX * TRX_NR_TS
Here you're accounting for up to 8 8-PSK bursts, you're taking into account those 2 dummy bytes (fro […]
Ack, I'll add some extra bytes for the header.