Attention is currently required from: Hoernchen, fixeria, laforge.

View Change

2 comments:

• File src/osmo-bts-trx/trx_if.h:

  • Patch Set #3, Line 11: OSMO_MAX(2 * (GSM_BURST_LEN + 2), (EGPRS_BURST_LEN + 2))

    `EGPRS_BURST_LEN` is known to be 3 times greater than `GSM_BURST_LEN` (because 8-PSK fits 3 bits per […]

    I know, see last comment line. Still, this code here is resolved at compile time as a constant expression by any decent compiler, and it auto-explains how the value is calculated.

  • Patch Set #3, Line 12: TRXD_BURST_SIZE_MAX * TRX_NR_TS

    Here you're accounting for up to 8 8-PSK bursts, you're taking into account those 2 dummy bytes (fro […]

    Ack, I'll add some extra bytes for the header.

To view, visit change 41660. To unsubscribe, or for help writing mail filters, visit settings.