[M] Change in osmo-hnbgw[osmith/1.6.2]: Make compatible with private sigtran structs

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email ) Change subject: Make compatible with private sigtran structs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736/comment/d0331254_2777ecb6?u… : PS1, Line 339: #ifdef SIGTRAN_PRIVATE_STRUCTS Did you think about actually defining the APIs here as static inline instead? #ifdef not SIGTRAN_PRIVATE_STRUCTS static inline struct osmo-sccp_intance *osmo_sccp_instance_next_conn_id(...) { return cnlink->hnbgw_sccp_user->ss7->sccp; } #endif -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: osmith/1.6.2 Gerrit-Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e Gerrit-Change-Number: 38736 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:06:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes