Attention is currently required from: neels, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/28984 )
Change subject: main: show just a brief talloc report for vty
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/osmo-upf/osmo_upf_main.c:
https://gerrit.osmocom.org/c/osmo-upf/+/28984/comment/7ae8223e_af083e92
PS1, Line 380: talloc_report
What's the point of printing a report for the VTY
context? I can understand doing this for tall_upf_ […]
well, libosmovty could also
have talloc memory leaks. But, surprisingly, I don't recall us ever having any. So
maybe indeed it's an idea to omit printing it from [every] application.
I think in the early days we had SIGUSR1/SIGUSR2 to differentiate which talloc contexts to
dump.
Either way, none of the options is perfect.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/28984
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1
Gerrit-Change-Number: 28984
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Aug 2022 20:02:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment