Attention is currently required from: neels, fixeria.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmo-upf/osmo_upf_main.c:

  • Patch Set #1, Line 380: talloc_report

    What's the point of printing a report for the VTY context? I can understand doing this for tall_upf_ […]

    well, libosmovty could also have talloc memory leaks. But, surprisingly, I don't recall us ever having any. So maybe indeed it's an idea to omit printing it from [every] application.

    I think in the early days we had SIGUSR1/SIGUSR2 to differentiate which talloc contexts to dump.

    Either way, none of the options is perfect.

To view, visit change 28984. To unsubscribe, or for help writing mail filters, visit settings.