22 Sep
2023
22 Sep
'23
12:02 a.m.
Attention is currently required from: jolly.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email )
Change subject: ASCI: Add UIC support to random access burst ......................................................................
Patch Set 5:
(1 comment)
File src/target/firmware/layer1/prim_rach.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34482/comment/3d661af7_90e2709b PS5, Line 65: l1s.rach.uic < 0 Is 0xff a valid UIC value? I guess not given that it's outside the value range of signed `int8_t`. Personally I would prefer an unsigned field, at least because it's easier to define it in TTCN-3 (no need to specify the negative integer encoding format).
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed
Gerrit-Change-Number: 34482
Gerrit-PatchSet: 5
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Comment-Date: Thu, 21 Sep 2023 22:02:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment