Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28328 )
Change subject: lchan_select: implement dynamic selection mode for assignment ......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS2:
commit log definitely needs expansion; manual probably too?
Done.
File src/osmo-bsc/lchan_select.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/a7484af6_cbe54d6a PS2, Line 229: /* Sort by TRX power is descending order (if needed) */
"in descending"?
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/2d671084_4c17aeaf PS2, Line 231: qsort(&trx_list[0], bts->num_trx, sizeof(trx), &qsort_func);
I'm also not liking the fact that you seem to be basically mixing logic for different alloc algorith […]
I though about having a separate function for dynamic mode, but then it would be 80% identical to this function... Let's see what the others think.