Attention is currently required from: laforge, pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    commit log definitely needs expansion; manual probably too?

    Done.

• File src/osmo-bsc/lchan_select.c:

  • Patch Set #2, Line 229: /* Sort by TRX power is descending order (if needed) */

    "in descending"?

    Done

  • Patch Set #2, Line 231: qsort(&trx_list[0], bts->num_trx, sizeof(trx), &qsort_func);

    I'm also not liking the fact that you seem to be basically mixing logic for different alloc algorith […]

    I though about having a separate function for dynamic mode, but then it would be 80% identical to this function... Let's see what the others think.

To view, visit change 28328. To unsubscribe, or for help writing mail filters, visit settings.