Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 )
Change subject: sbcap: Log info about messages received and trasmitted ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/sbcap_link.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/a41dd2dc_8b53bba9 PS1, Line 397: Transmitting Given that you're changing "Received" to "Rx", I suggest to use "Tx" here for consistency.
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/3727e0f3_78007760 PS1, Line 403: LOGPSBCAPC(link, LOGL_DEBUG, "Encoded message %s: %s\n", Isn't it redundant to print PDU name here? You're already printing it on line 398 ("Transmitting msg %s").