Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/sbcap_link.c:

  • Patch Set #1, Line 397: Transmitting

    Given that you're changing "Received" to "Rx", I suggest to use "Tx" here for consistency.

  • Patch Set #1, Line 403: LOGPSBCAPC(link, LOGL_DEBUG, "Encoded message %s: %s\n",

    Isn't it redundant to print PDU name here?
    You're already printing it on line 398 ("Transmitting msg %s").

To view, visit change 28819. To unsubscribe, or for help writing mail filters, visit settings.