Attention is currently required from: daniel, laforge, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email )
Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues
......................................................................
Patch Set 3:
(3 comments)
This change is ready for review.
Patchset:
PS1:
WIP, see comment on write callback
https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/c820b4d9_2ce6f4a0/
File src/core/gsmtap_util.c:
https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/fd6f571f_2548a01d
PS2, Line 441: }
msg doesn't need to be freed here?
Ah yes,
thanks. The case `OSMO_FD_READ` doesn't free the msgb, unlike `OSMO_FD_WRITE`, I was
only looking at the latter.
https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/9c2cf47b_92c44199
PS2, Line 493: * \param[in] osmo_io_mode Register \ref osmo_wqueue (1) or not (0)
Don't change the API param name, it's not
really needed.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0
Gerrit-Change-Number: 34743
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Oct 2023 13:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment