Attention is currently required from: jolly.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/33674
)
Change subject: ASCI: Add option to switch on or off ASCI support
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33674/comment/4531ea71_152475d9
PS2, Line 2088: struct msc_a *msc_a
(
rather add a struct gsm_network * arg. Nothing in this function uses an msc_a->*
member.
...or rather even only a 'bool asci_enable' arg?
some years ago i opposed it, but now my opinion is that a single global gsmnet pointer is
a good idea. we have bsc_gsmnet in osmo-bsc, i think no such thing in osmo-msc ... yet.
Maybe we can add that now, and then not need any arg at all here.
Up to you, not critical.
)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/33674
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753
Gerrit-Change-Number: 33674
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 13 Jul 2023 01:03:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment