Attention is currently required from: jolly.

Patch set 2:Code-Review +1

View Change

1 comment:

• File src/libmsc/msc_a.c:

  • Patch Set #2, Line 2088: struct msc_a *msc_a

    (
    rather add a struct gsm_network * arg. Nothing in this function uses an msc_a->* member.

    ...or rather even only a 'bool asci_enable' arg?

    some years ago i opposed it, but now my opinion is that a single global gsmnet pointer is a good idea. we have bsc_gsmnet in osmo-bsc, i think no such thing in osmo-msc ... yet. Maybe we can add that now, and then not need any arg at all here.

    Up to you, not critical.
    )

To view, visit change 33674. To unsubscribe, or for help writing mail filters, visit settings.