Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 )
Change subject: ran emulation: allow multiple reset attempts ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Patchset:
PS1: CR-1 due to missing 'mp_' prefix.
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/4ea2ef22_7356d... PS1, Line 526: while (attempts > 0) {
This is usually implemented in TTCN3 by means of "repeat;" keyword in the alt.
IMO, the loop approach is easier to read. Not only you would need to 'repeat', but also restart the timer and send the ts_BSSMAP_Reset again in the timeout altstep. But personally I would rather use 'for' here, it's a bit shorter:
for (var integer i := 0; i < g_ran_ops.bssap_reset_retries; i := i + 1) { ... }
Not critical, just a matter of preferences. You can keep this code as is.
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/4f7665eb_dd389... PS1, Line 143: bssap_reset_retries All module parameters star with 'mp_', please align the naming.