Attention is currently required from: Hoernchen, pespin.

Patch set 1:Code-Review -1

3 comments:

Patchset:
- Patch Set #1:
  CR-1 due to missing 'mp_' prefix.
File library/RAN_Emulation.ttcnpp:
- Patch Set #1, Line 526: while (attempts > 0) {
  This is usually implemented in TTCN3 by means of "repeat;" keyword in the alt.
  IMO, the loop approach is easier to read. Not only you would need to 'repeat', but also restart the timer and send the ts_BSSMAP_Reset again in the timeout altstep. But personally I would rather use 'for' here, it's a bit shorter:
```
  for (var integer i := 0; i < g_ran_ops.bssap_reset_retries; i := i + 1) { ... }
```
  Not critical, just a matter of preferences. You can keep this code as is.
File msc/MSC_Tests.ttcn:
- Patch Set #1, Line 143: bssap_reset_retries
  All module parameters star with 'mp_', please align the naming.

To view, visit change 27602. To unsubscribe, or for help writing mail filters, visit settings.