31 Jan
2022
31 Jan
'22
4:49 p.m.
Attention is currently required from: roox, laforge, tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27020 )
Change subject: GPS-DO support for icE1usb hardware ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/usb.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/27020/comment/79a32bfe_672f26a6 PS2, Line 805: intf_data->devh = devh; can't these lines here and in the else branch be moved below into the generic path?
https://gerrit.osmocom.org/c/osmo-e1d/+/27020/comment/67fcf2f0_08e62257 PS2, Line 929: if ((id->bInterfaceClass == 0xff) && (id->bInterfaceSubClass == 0xe1) && It'b be fine having defines for these values.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27020
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: If5e2a6b2dae0290ce3186009e68f618049ebf5ff
Gerrit-Change-Number: 27020
Gerrit-PatchSet: 2
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Reviewer: roox mardnh@gmx.de
Gerrit-Reviewer: tnt tnt@246tNt.com
Gerrit-Attention: roox mardnh@gmx.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: tnt tnt@246tNt.com
Gerrit-Comment-Date: Mon, 31 Jan 2022 16:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment