Attention is currently required from: roox, laforge, tnt.
Patch set 2:Code-Review +1
View Change
2 comments:
File src/usb.c:
Patch Set #2, Line 805: intf_data->devh = devh;
can't these lines here and in the else branch be moved below into the generic path?
Patch Set #2, Line 929: if ((id->bInterfaceClass == 0xff) && (id->bInterfaceSubClass == 0xe1) &&
It'b be fine having defines for these values.
To view, visit change 27020. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: If5e2a6b2dae0290ce3186009e68f618049ebf5ff
Gerrit-Change-Number: 27020
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: roox <mardnh@gmx.de>
Gerrit-Reviewer: tnt <tnt@246tNt.com>
Gerrit-Attention: roox <mardnh@gmx.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: tnt <tnt@246tNt.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 16:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment