Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email )
Change subject: Improve logging reading packets from gtp device
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-upf/upf_gtpu_echo.c:
https://gerrit.osmocom.org/c/osmo-upf/+/39419/comment/3a4e0337_36fe3819?usp… :
PS1, Line 219: return 0;
You're changing the logic: before your patch it
would return `-1`, but now it's returning `0` -- is […]
It's just a regular
ofd cb, the return code is not really used unless you pass -EBADF.
I changed it because imho it's just fine returning 0 since it's a expected code
path (even if we are not yet doing anything with it other than logging).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8
Gerrit-Change-Number: 39419
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Jan 2025 19:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>