[L] Change in libosmo-netif[master]: stream: Add server-side (segmentation) support for IPA

Attention is currently required from: arehbein, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 ) Change subject: stream: Add server-side (segmentation) support for IPA ...................................................................... Patch Set 10: Code-Review-1 (4 comments) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/6c22a2d7_5b571ab5 PS10, Line 540: osmo_stream_cli_set_addr(osc, "127.0.0.11"); better use 127.0.0.1 here, all IP addresses being available in linux specific iirc. https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/e3d5961c_a5eebe4b PS10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start); osmo_clock_gettime() everywhere. https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/f089df7d_f2c4134f PS10, Line 629: rc = clock_gettime(CLOCK_MONOTONIC, &now); osmo_clock_gettime. I don't even know how is that working as expected, since you are not using the proper API. https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/82e8ae27_3232c33a PS10, Line 684: rc = test_segm_ipa_stream_srv_run(tall_test, host, port, srv); we don't usually do this kind of return in tests. Simply exit(1) or assert() wherever something goes wrong. This makes it easier to debug. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c Gerrit-Change-Number: 33197 Gerrit-PatchSet: 10 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Jul 2023 08:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment