Attention is currently required from: arehbein, laforge.

Patch set 10:Code-Review -1

View Change

4 comments:

• File tests/stream/stream_test.c:

  • Patch Set #10, Line 540: osmo_stream_cli_set_addr(osc, "127.0.0.11");

    better use 127.0.0.1 here, all IP addresses being available in linux specific iirc.

  • Patch Set #10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start);

    osmo_clock_gettime() everywhere.

  • Patch Set #10, Line 629: rc = clock_gettime(CLOCK_MONOTONIC, &now);

    osmo_clock_gettime.
    I don't even know how is that working as expected, since you are not using the proper API.

  • Patch Set #10, Line 684: rc = test_segm_ipa_stream_srv_run(tall_test, host, port, srv);

    we don't usually do this kind of return in tests. Simply exit(1) or assert() wherever something goes wrong. This makes it easier to debug.

To view, visit change 33197. To unsubscribe, or for help writing mail filters, visit settings.