Attention is currently required from: jolly.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35778?usp=email )
Change subject: trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH ......................................................................
Patch Set 1:
(2 comments)
File src/host/trxcon/src/sched_lchan_pdtch.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35778/comment/c5a6b507_55d351ff PS1, Line 164: lchan->prim = msg I will add an `ASSERT` to make sure `lchan->prim` is NULL here.
https://gerrit.osmocom.org/c/osmocom-bb/+/35778/comment/4d8458da_dc9c81e3 PS1, Line 191: }
What happens to lchan->prim, if bid is not 3?
`lchan->prim` should remain allocated and assigned until `bid == 3` (4th burst) - this is when we want to confirm sending UL BLOCK.req to the upper layers, because burst timing matters.