pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26724 )
Change subject: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRequest/Response ......................................................................
Patch Set 1:
(4 comments)
Sounds like we should be creating src/hnbgw/ soon and move all hnbgw files there, since we'll be adding more code there. Even maybe thinking about splitting it to a new repository, specially since we'll now depend on libosmo-mgcp in osmo-hnbgw.
https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_ra... File include/osmocom/iuh/ranap_rab_ass.h:
https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_ra... PS1, Line 1: #pragma once This file in hnbgw specific afaict, so it must not go into osmo-iuh (libosmo-ranap/rua/sabp) include directory imho, but rather to include/osmocom/hnbgw/
https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_ra... PS1, Line 3: int ranap_rab_ass_req_decode(RANAP_RAB_AssignmentRequestIEs_t * rab_assignment_request_ies, const uint8_t *data, please put the "*" attached to the right.
https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c File src/ranap_rab_ass.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c@241 PS1, Line 241: * \ptmap[out] addr buffer to store extraced RTP stream IP address (length at least INET6_ADDRSTRLEN). extracted (same immediately below)
https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c@242 PS1, Line 242: * \ptmap[out] port pointer to store extraced RTP stream IP port number. worth mentioning whether it's network-byte order or host-byte-ordering.