Sounds like we should be creating src/hnbgw/ soon and move all hnbgw files there, since we'll be adding more code there. Even maybe thinking about splitting it to a new repository, specially since we'll now depend on libosmo-mgcp in osmo-hnbgw.

View Change

4 comments:

• File include/osmocom/iuh/ranap_rab_ass.h:

  • Patch Set #1, Line 1: #pragma once

    This file in hnbgw specific afaict, so it must not go into osmo-iuh (libosmo-ranap/rua/sabp) include directory imho, but rather to include/osmocom/hnbgw/

  • Patch Set #1, Line 3: int ranap_rab_ass_req_decode(RANAP_RAB_AssignmentRequestIEs_t * rab_assignment_request_ies, const uint8_t *data,

    please put the "*" attached to the right.

• File src/ranap_rab_ass.c:

  • Patch Set #1, Line 241: * \ptmap[out] addr buffer to store extraced RTP stream IP address (length at least INET6_ADDRSTRLEN).

    extracted (same immediately below)

  • Patch Set #1, Line 242: * \ptmap[out] port pointer to store extraced RTP stream IP port number.

    worth mentioning whether it's network-byte order or host-byte-ordering.

To view, visit change 26724. To unsubscribe, or for help writing mail filters, visit settings.