Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33690
)
Change subject: pySim/cards: Split legacy classes away from core SIM + UICC
......................................................................
Patch Set 4:
(2 comments)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33690/comment/67ce13fb_86eba0d8
PS4, Line 41: self._aids = []
thanks, this should be in the constructor.
Done
https://gerrit.osmocom.org/c/pysim/+/33690/comment/9f4d2de6_152df544
PS4, Line 319: SimCard
`UiccCardBase` is a [grand]child of `SimCard`, do we
really need `SimCard` here?
indeed. In our code model we don't need SimCard
here, but from a ETSI/3GPP point of view a [typical] Usim is UICC + SIM. The reason we
have the "wrong" relationship of UiccCardBase inheriting from SimCardBase
instead of CardBase is that the read_{binary,record} methods are identical.
Maye I should simply copy+paste those 10 lines of code and maeke UiccCardBase inherit from
CardBase rather than SimCard?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/33690
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id36140675def5fc44eedce81fc7b09e0adc527e1
Gerrit-Change-Number: 33690
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 19:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment