Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )
Change subject: vita demod by piotr krysik, modified ......................................................................
Patch Set 2:
(5 comments)
File Transceiver52M/grgsm_vitac/constants.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc5d57fe_d5da79bd PS2, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second Having "//" comments in a define looks dangerous to me, I'm not sure if first the comments are dropped or firt the preprocessor is run. In any case, I think we tend to use /**/ everywhere.
File Transceiver52M/grgsm_vitac/grgsm_vitac.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ba59ef2_8eef2d3b PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Please fix.
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c865ad_68bde2ad PS2, Line 38: void initvita();
Bad function definition - void initvita() should probably be void initvita(void)
Please fix.
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2bd6c0cd_05adc4da PS2, Line 62: };
adding a line without newline at end of file
Please fix.
File Transceiver52M/grgsm_vitac/viterbi_detector.cc:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3fd9ef39_33dcc2b5 PS2, Line 1: /* -*- c++ -*- */ All files are named ".cpp", why is this one named ".cc"?