Attention is currently required from: Hoernchen.

View Change

5 comments:

• File Transceiver52M/grgsm_vitac/constants.h:

  • Patch Set #2, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second

    Having "//" comments in a define looks dangerous to me, I'm not sure if first the comments are dropped or firt the preprocessor is run.
    In any case, I think we tend to use /**/ everywhere.

• File Transceiver52M/grgsm_vitac/grgsm_vitac.h:

  • Patch Set #2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,

    Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.

    Please fix.

  • Patch Set #2, Line 38: void initvita();

    Bad function definition - void initvita() should probably be void initvita(void)

    Please fix.

  • Patch Set #2, Line 62: };

    adding a line without newline at end of file

    Please fix.

• File Transceiver52M/grgsm_vitac/viterbi_detector.cc:

  • Patch Set #2, Line 1: /* -*- c++ -*- */

    All files are named ".cpp", why is this one named ".cc"?

To view, visit change 30415. To unsubscribe, or for help writing mail filters, visit settings.