Attention is currently required from: laforge, lynxis lazus, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing ......................................................................
Patch Set 13:
(9 comments)
File src/ss7_as_loadshare_tcap.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c45ed608_c0c670... : PS8, Line 379: /* FIXME: use UTDS */
It's used in asp_loadshare_tcap_sccp. @lynxis@fe80. […]
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/ae615bae_c7973f... : PS8, Line 380: static int sent_back_utds(struct osmo_ss7_as *as,
I need to investigate about this: […]
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d3c146a8_ba6b0a... : PS8, Line 473: * \return
return is not described.
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fef52002_7171fa... : PS8, Line 475: static int asp_loadshare_tcap_sccp(struct osmo_ss7_asp **rasp, struct osmo_ss7_as *as, uint32_t opc, uint32_t dpc,
imho the EPROTONOSUPPORT should be dropped, and return rasp instead.
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d2ccee28_395775... : PS8, Line 560: sent_back_utds(as, xua, sua, SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE);
I need to investigate about this: […]
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6fe54d5c_ad7395... : PS8, Line 607: * @return 0 on success
afaiu this should only return the asp, no need to return an rc?
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c8996526_0b1472... : PS8, Line 921: /** Called when the ASP is going down or free'd
Why?
Done
File src/ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/1d29a837_b822b8... : PS8, Line 1216: tcap_asp_down(asp);
nooo way you are calling this here. Put it where it belongs in the FSM.
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/602f6632_cb2af2... : PS8, Line 1344: tcap_asp_down(asp);
I can have a look.
Done