Attention is currently required from: laforge, lynxis lazus, pespin.

View Change

9 comments:

• File src/ss7_as_loadshare_tcap.c:

  • Patch Set #8, Line 379: /* FIXME: use UTDS */

    It's used in asp_loadshare_tcap_sccp. @lynxis@fe80. […]

    Done

  • Patch Set #8, Line 380: static int sent_back_utds(struct osmo_ss7_as *as,

    I need to investigate about this: […]

    Done

  • Patch Set #8, Line 473: * \return

    return is not described.

    Done

  • Patch Set #8, Line 475: static int asp_loadshare_tcap_sccp(struct osmo_ss7_asp **rasp, struct osmo_ss7_as *as, uint32_t opc, uint32_t dpc,

    imho the EPROTONOSUPPORT should be dropped, and return rasp instead.

    Done

  • Patch Set #8, Line 560: sent_back_utds(as, xua, sua, SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE);

    I need to investigate about this: […]

    Done

  • Patch Set #8, Line 607: * @return 0 on success

    afaiu this should only return the asp, no need to return an rc?

    Done

  • Patch Set #8, Line 921: /** Called when the ASP is going down or free'd

    Why?

    Done

• File src/ss7_asp.c:

  • Patch Set #8, Line 1216: tcap_asp_down(asp);

    nooo way you are calling this here. Put it where it belongs in the FSM.

    Done

  • Patch Set #8, Line 1344: tcap_asp_down(asp);

    I can have a look.

    Done

To view, visit change 41309. To unsubscribe, or for help writing mail filters, visit settings.